Hi all,
Unfortunately this is a known issue between Gutenberg and ACF.
The issue was raised with the Gutenberg team who will look into a solution for WP 5.0.1.
We have mentioned this issue along with some other known ones in our latest blog post here. Please be sure to have a read: https://www.advancedcustomfields.com/blog/the-night-before-gutenberg/
You can follow the GitHub issue with WP here: https://github.com/WordPress/gutenberg/issues/12571#issuecomment-443984858
Thanks for your patience whilst we sort out these issues with the WP team.
I’ll mark this as solved and link to a duplicate ticket which you can follow here: https://support.advancedcustomfields.com/forums/topic/on-wp-5-0-with-classic-editor-1-0-installed-cannot-edit-field-groups/
Hi all,
WP 5.0 with Classic Editor 1.0 Installed is causing a WSOD (White Screen of Death) when editing field groups.
To fix: Go to Settings > Writing and then set “Default editor for all users” to “Classic Editor” and “Allow users to switch editors” to “No”.
Please follow the full discussion with plugin developers here: https://wordpress.org/support/topic/classic-editor-is-blank-in-wordpress-5-0/
Thanks
Elliot
Hi all,
Thanks for the bug report. I am currently in communication with the Classic Editor developers about this issue here: https://wordpress.org/support/topic/classic-editor-is-blank-in-wordpress-5-0/#post-10955802
Hi @benabaird
Thanks for the bug report and sorry for my delayed reply.
This is a good idea and will be easy to implement.
Please edit the file “includes/form.php” and find the line ~160:
// action
do_action('acf/save_post', $post_id);
Then change it to this:
// Filter $_POST data for users without the 'unfiltered_html' capability.
if( !current_user_can('unfiltered_html') ) {
$_POST['acf'] = wp_kses_post_deep( $_POST['acf'] );
}
// action
do_action('acf/save_post', $post_id);
We have tested this and can confirm it works correctly for author users who don’t have the ‘unfiltered_html’ capability:
https://codex.wordpress.org/Roles_and_Capabilities#unfiltered_html
Let me know your thoughts on the fix and I’ll aim to release a patch shortly.
Thanks
Elliot
Thanks for the reply, and for calling me out on this.
I agree with you, and am also frustrated that I haven’t solved this yet.
The good news is that I have been collecting information from a few support tickets on this same subject and have plans to fix this as soon as possible.
This year has been a big one, and I haven’t been able to tick off all the to-do’s on my list. This issue effects both the free and PRO users, so please don’t think this has anything to do with finances.
Right now, I am dedicating all my time to Gutenberg related work and trying my hardest in all areas to make sure that WordPress continues to function as a flexible and reliable CMS.
The issue itself is quite simple. I had made use of the $found
parameter in wp_cache_get() as per the documentation (https://codex.wordpress.org/Function_Reference/wp_cache_get), but it turns out that some object caching does not respect/modify this parameter.
I’m happy to simplify my code and will do so after the Guten-dust settles.
Your help is and will be greatly appreciated. If not already, can you please open up a support ticket here (https://www.advancedcustomfields.com/contact/) and ask for me personally (Elliot) to discuss this object caching issue with? This community forum is a great way for devs to communicate, but is not my primary area to work on bugs.
Thanks
E
@pasadenaweb Thanks for the question. Unfortunately, I have not made any progress with this as all my attention is dedicated to Gutenberg issues at the moment.
Thanks for your understanding.
Hi all,
@twgerard is having some issues posting a reply and has asked me to pass on the following:
Here is a link to the repository:
https://github.com/TWGerard/acf-anything-link
Thanks
Elliot
Hi all,
Sorry about this issue, it’s a minor JS mistake.
Please edit the file “includes/gutenberg/assets/js/acf-blocks.js” on line 90:
From:
if( !wp || !wp.blocks || wp.blocks.registerBlockType ) {
To:
if( !wp || !wp.blocks || !wp.blocks.registerBlockType ) {
I have also updated the plugin files online to re-download.
Hi @jjarolim
Thanks for the feedback.
We have recently fixed the issue you mentioned above regarding the radio inputs, and have also added in an option to define which “mode” the block loads in + another setting to disable the “mode toggle”!
Stay tuned on our progress here: https://github.com/AdvancedCustomFields/acf/issues/71
Thanks for the email,
Elliot here – ACF dev.
ACF Blocks are dynamic, meaning the “HTML” is left empty, and all data is saved as an object within the “HTML comment”.
ACF then renders the HTML via your “render_callback” usng this data. I hope this info is helpful.
Hi @marcelo2605
Thanks for the email,
Elliot here – ACF dev.
Your version numbers are a little confusing, can you please confirm which versions of the following are you using?
– ACF PRO
– Gutenberg
– WordPress
After upgrading a website from ACF4 to ACF5 you will be prompted to upgrade the database. This prompt is visible when logged into the website’s dashboard. If for some reason this prompt does not appear, please consider the following possibilities:
1. You have already upgraded in the past. The upgrade prompt will only run once, even if you have rolled back.
2. There may be another plugin / theme code hiding the prompt.
3. Your DB wp_options table contains a modified “acf_version” value.
An easy way to check if the upgrade has been run in the past is to check your database wp_options table and find the “acf_version” row. This option contains the last known version of ACF installed. If the version is higher than 5.0, the upgrade has already run and will not appear.
It is possible to force ACF to run the upgrade again by editing this row in your DB and changing the option value to “4.4.12”. Please be sure to backup your database before making this change to avoid any “duplicate data” created in the second upgrade.
For now, you can always rollback to ACF4. There is no data loss with this and is a good solution to get your site working until you can test the update on a dev/staging site.
https://www.advancedcustomfields.com/resources/upgrade-guide-version-5/
If you’re still having troubles, please contact support.
http://www.advancedcustomfields.com/contact/
Testing on a dev site is always a good idea, but is it possible that you forgot to run the DB upgrade after updating the plugin?
Please be sure to read over the upgrade guide here:
https://www.advancedcustomfields.com/resources/upgrade-guide-version-5/
Let me know how you go.
Hi guys.
Once you update to version 5 you will be prompted for a Database Upgrade. ACF 5 will configure some settings and ready your fields. https://www.advancedcustomfields.com/resources/upgrade-guide-version-5/
Please be sure to run the DB Upgrade, otherwise, your fields will not appear.
Hope this helps.
Thanks
Elliot
Hi @studiok7
Thanks for the bug report and screen recording 🙂
I’ve successfully found and fixed the issue, and re-uploaded the plugin files online for you to test.
Can you please re-download the ACF PRO plugin files to get the patched JS?
Tip: You can also trick ACF into re-updating itself by editing the main “acf.php” plugin file and changing the two references of “5.7.6” to “5.7.5”. This will allow WP to check for plugin updates and you can then re-update the plugin 🙂
Hi @wilirius
Adding support for deprecated JS functions is something I spent some time solving in ACF v5.7.
In version 5.7.6, technically the acf.validation.lockForm()
no longer exists, however, it is still usable.
The acf.validation object inherits all functions from its “prototype” which you can inspect here acf.validation.__proto__
. This object does contain the lockForm() function so you can continue using acf.validation.lockForm()
without any issues 🙂
Hi @freshsauce
Please see the Known issue for 5.7.2 here:
https://www.advancedcustomfields.com/resources/known-issues/
Hi @howdy_mcgee
Thanks for the bug report,
Elliot here – ACF dev.
Sorry about this issue, it is easily solved.
Can you please edit the ‘api-terms.php’ file in question and change the acf_get_taxonomy_labels() function to:
function acf_get_taxonomy_labels( $taxonomies = array() ) {
// default
if( empty($taxonomies) ) {
$taxonomies = acf_get_taxonomies();
}
// vars
$ref = array();
$data = array();
// loop
foreach( $taxonomies as $taxonomy ) {
// vars
$object = get_taxonomy( $taxonomy );
$label = $object->labels->singular_name;
// append
$data[ $taxonomy ] = $label;
// increase counter
if( !isset($ref[ $label ]) ) {
$ref[ $label ] = 0;
}
$ref[ $label ]++;
}
// show taxonomy name next to label for shared labels
foreach( $data as $taxonomy => $label ) {
if( $ref[$label] > 1 ) {
$data[ $taxonomy ] .= ' (' . $taxonomy . ')';
}
}
// return
return $data;
}
Hi guys
Thanks for the email,
Elliot here – ACF dev.
Thanks for the bug report and sorry for the JS errors.
We have quickly fixed the issue and re-uploaded the plugin files online.
Can you please re-download the ACF PRO plugin files from your account, this should solve the problem.
https://www.advancedcustomfields.com/my-account
Tip: You can also trick ACF into re-updating itself by editing the main “acf.php” plugin file and changing the two references of “5.7.2” to “5.7.1”. This will allow WP to check for plugin updates and you can then re-update the plugin 🙂
update – JS files updated to fix an issue where post has no title / content
update – JS files updated to fix an issue where uploaded attachments are not connected to the post (if the CPT does not support “editor”).
Hi @wpmark
Thanks for the reply.
I’m not seeing any obvious settings in MAMP PRO. I’ll jump online and find some tutorials for setting up local object caching. If you know of any good ones, please let me know.
Hi guys
Object caching is definitely something that got forgotten about in the last few years, my bad.
I’m currently wrapping up work on version 5.7, and think this is a good time to focus on caching. The first step is for me to replicate the issue. Can someone provide some simple info about setting up caching on a local site?
Is it as simple as installing a plugin? Or do I need to configure settings in my local environment. For reference, I use a combination of MampPRO and Local by flywheel for local testing.
Hi @howdy_mcgee
Thanks for the topic,
Elliot here – ACF dev.
Can you please update to the latest 5.7 (currently 5.7.0-RC2) and let me know if this issue is resolved?
Welcome to the Advanced Custom Fields community forum.
Browse through ideas, snippets of code, questions and answers between fellow ACF users
Helping others is a great way to earn karma, gain badges and help ACF development!
We use cookies to offer you a better browsing experience, analyze site traffic and personalize content. Read about how we use cookies and how you can control them in our Privacy Policy. If you continue to use this site, you consent to our use of cookies.