Hi all,
Elliot here – ACF dev.
Thanks for the bug report. I am currently reviewing similar tickets both on our helpdesk and the WordPress trac. This issue looks to be related to the use of date_default_timezone_set()
within WordPress 5.3, and is not specific to ACF, but will also affect other parts of WP such as “scheduled posts’.
Please read this reply from one of the WordPress moderators: https://wordpress.org/support/topic/read-this-first-wordpress-5-3-master-list/#post-12124062
If my prediction is correct, the values saved into the DB (from our date related field types) should be correct. The problem occurs only when loading the value via get_field()
which will “format” the value via the date_i18n()
function, triggering the issue caused by the use of date_default_timezone_set()
.
Please let me know if you are able to resolve this issue by removing the date_default_timezone_set()
function from your theme / plugin. This will provide helpful feedback to myself and the WP team 🙂
Hi all,
Elliot here – ACF dev.
I was made aware of this forum thread via the following GitHub issue: https://github.com/AdvancedCustomFields/acf/issues/246#event-2786440261
Please join me on GitHub to discuss replicating this issue so I may debug the problem.
Thanks
Elliot
Hi All,
This is a known issue in the Gutenberg project, but no solution has yet been announced.
I’m sorry to report that this is not fixable from my end.
Hi @jnicol
Thanks for the topic.
This is an interesting one, and one that I don’t yet have a solution for. Hopefully the following info can help shine some light on the problem.
To allow the ACF template functions such as get_field()
to work as expected within the block callback/template, we had to “inject” the block values into the “acf/pre_load_metadata” filter. This filter is run when ACF attempts to load a meta value for any given key/object_id.
This “injecting” behavior is overwriting/preventing your code from reading from the newly “setup postdata”.
I’ll have a think about how we can add compatibility with this function, but am not yet sure on the solution :S
Hi all,
This bug has been patched, and the ACF PRO plugin files have been re-uploaded online.
Please manually path this fix by editing the file “includes/api/api-helpers.php” and change the acf_is_block_editor()
function on line ~5051 to:
/**
* acf_is_block_editor
*
* Returns true if the current screen uses the block editor.
*
* @date 13/12/18
* @since 5.8.0
*
* @param void
* @return bool
*/
function acf_is_block_editor() {
if( function_exists('get_current_screen') ) {
$screen = get_current_screen();
if( method_exists($screen, 'is_block_editor') ) {
return $screen->is_block_editor();
}
}
return false;
}
Hi all
Thanks for the bug report.
I suspect this issue is with “front-end” forms only, and will have this patched today 🙂
@hodephinitely Thanks for the report. Sorry to quote myself again, but can you please open a new support ticket via the following link, and we can work together to diagnose the issue: https://www.advancedcustomfields.com/contact/
@palmerijosh Thanks for the reply.
I’m confident that our object caching is working well in 5.7.12, so I suspect there is something else at play.
I’m happy to take a look at your site and help debug the issue. Can you please open a support ticket via the following link and ask for me (Elliot): https://www.advancedcustomfields.com/contact/
It would be great to get access to your site (or a staging site) so I can login and test the object caching / SQL queries.
Hi @johnstaples
Thanks for the bug report. I’ve just tested out the “Add new” post page in WP and was not able to replicate any issues saving custom field data.
Can you please spin up a fresh install using the “Local by flywheel” app and test out ACF on a vanilla website?
Please let me know if you were able to replicate the issue.
Hi @timmy28x
Thanks for the questions.
1. No, the 5.8.0-beat3 has remained untouched, and does not contain any of the new functionality. I plan to release a new 5.7.12 version tomorrow to address the bugs in 5.7.11, then begin work on 5.8.0-beta4 which will get all the new updates from 5.7.x
2. Yes, our update system will allow betas to appear in the wp-admin plugins page 🙂
3. Good question. In theory, there should be no issues. We are not planning to make any breaking changes from the current 5.8.0-beta version. We do plan to change the way values are stored within the block JSON, but we will be sure to do this in a “backwards compatible” manor 🙂
Hi @curtisb
Thanks for the honest feedback. I’m first to admit this was a buggy release.
I would like to clarify that in no way am I trying to “hide” these bugs by asking users to re-download the plugin, this is simply a way to get those bugs fixed, and allow users to test out the fix. I am planning to release a new 5.7.12 version tomorrow which will include all the fixed bugs. I would rather release a single version to fix all bugs, than multiple versions each day.
The Options page slashes value caught us by surprise, but luckily was one that we could fix quickly and confidently.
I’m not sure that I am familiar with the “acf/format_value” filter issue. I’ll search around for reports on this.
I’ll definitely reflect on this for sure.
Thanks again.
Elliot
Thanks for the reply. Can you please open a support ticket via the following link so we can further investigate the issue on your site? https://www.advancedcustomfields.com/contact/
@dd_james Thanks for the info. This issue sounds like fields are being incorrectly cached in storage.
Can you please open a support ticket via the following link and include a .json export + PHP code to replicate the issue?
https://www.advancedcustomfields.com/contact/
@room34 Thanks for the update. Can you please open a new support ticket via the following link, and we can work together to diagnose the issue: https://www.advancedcustomfields.com/contact/
Hi all,
The issue sounds like ACF is incorrectly “re-adding” the field group metabox after a “post attribute change” is detected.
This is possible if the field group is missing a “key” setting.
If you are using PHP to register the field group, can you please check your PHP field group and ensure that the field group itself has a unique key?
My apologies for the issues in version 5.7.11.
I am confident we have found and fixed the issue.
Can you please re-download the ACF PRO plugin files and test the issue?
An easy way to re-download is to edit the main acf.php plugin file and change the version number ‘5.7.11’ down to ‘5.7.10’
– please note the version number appears twice in this file and both will need to be changed
– after this change is made, please update the plugin as per normal and it will update to 5.7.11 (including the new fix)
Thanks for the info,
Elliot here – ACF dev.
My apologies for the issues in version 5.7.11.
I am confident we have found and fixed the issue.
Can you please re-download the ACF PRO plugin files and test the issue?
An easy way to re-download is to edit the main acf.php plugin file and change the version number ‘5.7.11’ down to ‘5.7.10’
– please note the version number appears twice in this file and both will need to be changed
– after this change is made, please update the plugin as per normal and it will update to 5.7.11 (including the new fix)
Hi all
Thanks for the bug report.
The issue sounds like ACF is incorrectly “re-adding” the field group metabox after a “post attribute change” is detected. This is possible if the field group is missing a “key” setting.
Can you please check your PHP field group and ensure that the field group itself has a unique key?
My apologies for the issues in version 5.7.11.
I am confident we have found and fixed the issue.
Can you please re-download the ACF PRO plugin files and test the issue?
An easy way to re-download is to edit the main acf.php plugin file and change the version number ‘5.7.11’ down to ‘5.7.10’
– please note the version number appears twice in this file and both will need to be changed
– after this change is made, please update the plugin as per normal and it will update to 5.7.11 (including the new fix)
Thanks for the feedback!
Thanks for the feedback. Glad to hear things are working again!
@jamiepr23 If the update does not appear after changing your version number, please manually re-download the plugin files from your account online: https://www.advancedcustomfields.com/my-account
@bung55 Thanks for helping, great info!
Hi there
Thanks for the email,
Elliot here – ACF dev.
My apologies for the issues in version 5.7.11.
I am confident we have found and fixed the issue.
Can you please re-download the ACF PRO plugin files and test the issue?
An easy way to re-download is to edit the main acf.php plugin file and change the version number ‘5.7.11’ down to ‘5.7.10’
– please note the version number appears twice in this file and both will need to be changed
– after this change is made, please update the plugin as per normal and it will update to 5.7.11 (including the new fix)
Hi all
Thanks for the email,
Elliot here – ACF dev.
My apologies for the issues in version 5.7.11.
I am confident we have found and fixed the issue.
Can you please re-download the ACF PRO plugin files and test the issue?
An easy way to re-download is to edit the main acf.php plugin file and change the version number ‘5.7.11’ down to ‘5.7.10’
– please note the version number appears twice in this file and both will need to be changed
– after this change is made, please update the plugin as per normal and it will update to 5.7.11 (including the new fix)
Hi all
Thanks for the email,
Elliot here – ACF dev.
My apologies for the issues in version 5.7.11.
I am confident we have found and fixed the issue.
Can you please re-download the ACF PRO plugin files and test the issue?
An easy way to re-download is to edit the main acf.php plugin file and change the version number ‘5.7.11’ down to ‘5.7.10’
– please note the version number appears twice in this file and both will need to be changed
– after this change is made, please update the plugin as per normal and it will update to 5.7.11 (including the new fix)
Welcome to the Advanced Custom Fields community forum.
Browse through ideas, snippets of code, questions and answers between fellow ACF users
Helping others is a great way to earn karma, gain badges and help ACF development!
We use cookies to offer you a better browsing experience, analyze site traffic and personalize content. Read about how we use cookies and how you can control them in our Privacy Policy. If you continue to use this site, you consent to our use of cookies.