Hi Elliot.
Unfortunately, I didn’t have too much time to really find what causes the problem. I just compared the final HTML codes of the ACF Option page: with active Formidable and without. I found that we miss those scripts when Formidable is on. It re-declares the scripts somehow.
Since I needed some fast temporary solution, I just linked those 2 scripts “manually”. By and large, we miss some other scripts too when Formidable is on, but since these two were enough to make link button work, I stopped on them. I also don’t know where ACF registers these two or maybe WP itself does this for all admin pages? When I have more time, I will study this problem more carefully.
Sorry for not being too helpful.
Temporary solution:
add_action( 'admin_init', 'wpuxss_admin_scripts' );
function wpuxss_admin_scripts()
{
global $pagenow;
if (( $pagenow == 'admin.php' ) && ($_GET['page'] == 'acf-options') )
{
wp_enqueue_script( 'wplink', home_url('/wp-includes/js/wplink.js') );
wp_enqueue_script( 'popup', home_url('/wp-includes/js/tinymce/plugins/wpdialogs/js/popup.js') );
}
}
Hello Elliot,
I am experiencing similar problem with ACF 4.2.2 (Option page 1.2.0) right now. When I deactivate Formidable 1.07.01 the problem is gone. The problem is only for Options page and for WYSIWYG link button.
Uncaught TypeError: Object [object Object] has no method 'wpdialog'
in the wp-includes/js/tinymce/wp-tinymce.php line 24
Hi Elliot,
Thanks for explanation. It makes sense to me.
Actually absence of a class is not a big deal for me personally, I have resolved this by using [type=”submit”].acf-button
But please consider that:
- Many plugins use class ‘button-primary’ (and other button classes) for their buttons successfully. For all I know, it’s not a common practice to use this class in jQuery to assign some functionality to the button.
- WordPress itself uses this class (and some other for the same button) mostly for proper styling. For example, admin theme developers can use it to identify main “blue button” of the page and redesign it. If some plugin does not have a proper class its buttons should be designed separately. (ACF is a popular plugin, though, so developers can consider to create a solution especially for it like I did it.)
- You can just add an ID like “acf-option-page” (it’s a single button per page even in case someone has a few Options Pages). I think it may be helpful for other plugin developers too.
Anyway, thank you. I consider your plugin the best WordPress developers’ framework at the moment.
I understand, it is so hard…
Hi Elliot and others,
I would love to have it implemented this way:
It should work like Adobe Photoshop layer groups. One can select a few fields (layers) and group them to the Row, then one can sort fields inside Row, and also drag the Row just like a single field. Context menu will work well I think, maybe also buttons on the footer bar. Also it will make possible to drag fields in/out the Row.
As for “right now” solution: I wrote a small plugin Toolbar Publish Button (it is available on the wordpress.org) that allows my client at least get rid of excessive scrolling. I don’t think that they actually confuse the fields, it’s just a bit inconvenient to scroll constantly when saving them. Maybe it will be helpful to some of you.
