Support

Account

Register Login

Forum Replies Created

  • … in case of those frameworks that support making of premium software products LGPL, MIT, or similar licenses are better than GPL …

    They may be… but WordPress is already licensed under the GPL. So there’s thousands of people to get agreement from if that was going to change 😉

    But, what it leaves off is that if you do this your premium plugin will become open source.

    It’s not just including ACF in a premium plugin that makes it GPL’ed – it’s also creating the premium plugin as a derivative of WordPress (unless it was very clearly not derivative… but that would be hard to argue IMO!)

  • I would like to embed the free version of ACF, but, if my understanding is correct ACF is licensed as GPL. GPL requires that if I include ACF in my premium plugin, then my premium plugin must also be GPL.

    Yes that would be a correct understanding of the GPL.

    Aside from that though, even if you don’t include ACF, as John stated it is quite possible your plugin could be judged to be a derivative of WordPress… which would mean it has to be GPL’ed anyway.

    However, as I’ve written here, I think the statements in the article on including ACF in a plugin also contravene the GPL.

  • While legally GPL doesn’t change based on what the original developer wants, ethically I think you have to think about it.

    This is a good point, and I’ve also thought and read a lot more about this since my original post. Yes, as a fellow programmer, I want to support Elliot, and would be loathe to suggest anyone considers not doing so. Yes you could get the code from anywhere for free (and distribute it yourself anywhere for free), but if everyone does that, Elliot’s going to have to go get another job and stop working on ACF, so you’re not doing yourself any favours in the long run (much less Elliot!). A much better option would be just to consider the ACF licensing fee as a ‘donation’ to Elliot to thank you for his excellent work. 🙂 (Or even better, contract him to develop some bespoke support and addons??)

    Having said that though, I have to say I’ve come to the conclusion that the Distributing ACF in a plugin / theme page is misleading and unethical in itself. Why is that? Because as well as us respecting Elliot and the work he has put into ACF, Elliot also needs to respect WordPress and the work put into WordPress by thousands of other developers. There are good reasons why WordPress is licensed under the GPL, and as a derivative of WordPress, ACF (including ACF Pro) must also be (and quite rightly is) GPL-licensed.

    The restrictions put around the distribution of ACF Pro are therefore misleading because they take advantage of the fact that anyone reading them who is going to be impacted by them is not aware of their rights while using GPL-licensed software. That is, the restrictions (apart from the license key distribution) are not enforceable, and – depending on your view – also not ethical and shouldn’t be stated in the first place.

    In particular, the stipulation that it must be ‘made clear in the copyright / information that the ACF PRO files are not to be used or distributed outside of the premium theme/plugin’ would appear to contravene the GPL’s restriction on adding additional restrictions to the license, which gives the user freedom to redistribute it as they see fit.

    I don’t mean to imply this is intentional on Elliot’s part – he’s stated above he doesn’t know much about licensing – but when it has the end result of disrespecting the license of the software it is built upon (WordPress) while simultaneously requesting respect of its own license (which is the same license), it’s ingenuous at best.

    I don’t say any of this in an attempt to disrespect Elliot or the countless hours he has put into ACF (which we have all benefited from) – and I should state that I do use a developer license for ACF Pro – but I think that it would be wise to reconsider ACF’s stance on the GPL so that its users aren’t misled of their rights when using WordPress.

  • I’m not sure if this is the same bug, but for anyone coming across this, this now may be resolved – see https://support.advancedcustomfields.com/forums/topic/choice-field-other-repeater-issue/ for details.

  • It doesn’t seem like it’s possible to do fully nested tabs – using the endpoint setting you can finish one set of tabs and start a new one, but it’s not really nested: you can’t go back to your original set of tabs and start a new tab.

  • +1 from me too! Awesome idea!

  • This addon plugin purports to add this functionality:

    https://wordpress.org/plugins/location-nav-menu-for-acf/

    I haven’t used it yet so can’t vouch for it, but I came across it while researching the same possibilities.

  • This is cool! Awesome work @wube, and huge props to @elliot for being so responsive to contributions 🙂

  • Got it, thanks for taking the time to come here and answer Elliot!

  • Just to add, for @infoircary-com, your code is great, but I have come across a couple of deficiencies:

    – if taxonomy is not the first location for the field, it won’t work
    – if you’re expecting an image field to return an image object, you’ll only get an attachment ID

    Those can both be worked around on a small scale but just thought I’d point it out, maybe we can work on enhancing the code to be more bulletproof if it’s not going to make it into ACF Core anytime soon 🙂

  • Thanks so much for this code guys. I was just about to start trying to query the options table in a custom way and get the taxonomy name and term_id from the option name! ugh

  • Thanks James, that makes sense. 🙂

    Can I submit this as a feature request? I think it would be possible but would obviously require a bit of work. Let me know if you’d rather me re-post this in the feature requests forum.

  • Thanks James – that makes sense. My question was more around the prohibition on including ACF Pro in a free theme or plugin – according to the GPL, that would be ok to do, right?

  • This is an awesome idea!

  • Thanks for the reply @jasonblackdog – I mentioned I was already on ACF Pro 🙂

  • Just here to say a ‘me too’…. although I’m not sure if it’s exactly the same problem.

    After upgrading an older install to ACF Pro 5, I’ve realised I’m unable to add any new fields at all. I don’t have the old field groups in the interface anymore (they were exported to PHP and and are included in the theme), so I’m creating a brand new field group. That works fine, but any fields created within it do not save – on saving, the page just loads again with no fields.

    I’ll probably get around this for now by writing it all in the PHP; I was just hoping to save myself a bit of time by create complex fields in the interface so I didn’t have to write them all manually.

    Still interested in a fix if anyone has managed to solve this – if indeed this is the problem the OP was seeing!

  • Note, if the above isn’t working for you, you may have a different user ID. Replace the number 1 in the code above with wp_get_current_user()->ID

  • Hey mediawerk, thanks very much for your reply.

    Yeah it looks like the size isn’t actually being returned – even though the size definitely does exist. I was wondering if it was perhaps a problem in ACF – or something that has changed? I’ve been using the same code in quite a few sites and it’s been working fine for some time, but I recently upgraded to ACF Pro…

    Here’s the output:

    Array
(
    [ID] => 659
    [id] => 659
    [title] => MOT_WAPOL_D2_ 110
    [filename] => MOT_WAPOL_D2_-110.jpg
    [url] => http://###/uploads/2015/07/MOT_WAPOL_D2_-110.jpg
    [alt] => 
    [author] => 1
    [description] => 
    [caption] => 
    [name] => mot_wapol_d2_-110
    [date] => 2015-07-10 00:58:30
    [modified] => 2015-07-10 00:58:30
    [mime_type] => image/jpeg
    [type] => image
    [icon] => http://###/wp-includes/images/media/default.png
    [width] => 3504
    [height] => 2336
    [sizes] => Array
        (
            [thumbnail] => http://###/uploads/2015/07/MOT_WAPOL_D2_-110-150x150.jpg
            [thumbnail-width] => 150
            [thumbnail-height] => 150
            [medium] => http://###/uploads/2015/07/MOT_WAPOL_D2_-110-300x200.jpg
            [medium-width] => 300
            [medium-height] => 200
            [large] => http://###/uploads/2015/07/MOT_WAPOL_D2_-110-1024x683.jpg
            [large-width] => 960
            [large-height] => 640
        )

    As I mentioned before, the size is coming through fine everywhere else, including in the ‘Preview size’ setting in the Image field settings in ACF.

    However… I think I just found the problem – possibly a bug! I’m actually using a field on an options page (so my code is $image = get_field('my_image',"options");). When I don’t use it on an options page, all the sizes come through ok!

    Is anyone else able to replicate this?

Viewing 18 posts - 1 through 18 (of 18 total)