• curtisb

• in reply to: ACF PRO 5.7.11 bugs (and it's solution) just caused a massive loss of confidence
• February 15, 2019 at 12:53 am

@elliot For the acf/format_value issue, if you haven’t received any reports for it, it’s possible I was doing something very unusual.

qtranslate saves all translates in the same fields, separated by a syntax, something like this [:en] english here [:es] spanish here. By default it gives you English, but I wanted to get unfiltered full value with all languages.

// * Removing filter so that we get the raw untranslated value (acf-qtranslate uses acf/format_value)
remove_all_filters('acf/format_value');
$fields = get_fields($post_id);

This did the trick for me. But after 5.7.11, this also caused all of the field key names in the response to turn into IDs (“text_field_name” turned into “field_5bfd7724ed94”).

I already refactored it to work without remove_all_filters so I’m not stuck on it. If nobody else has reported it perhaps there’s not an issue especially since I was using a heavy handed technique in the first place (remove_all_filters)

• curtisb

• in reply to: ACF PRO 5.7.11 bugs (and it's solution) just caused a massive loss of confidence
• February 15, 2019 at 12:35 am

@elliot I appreciate your response. I had a feeling it was a way of deploying hotfixes quickly, vs trying to hide the bugs – but thank you for clarifying. I was a little more frustrated in the moment yesterday, so apologies for the bluntness.

I would definitely recommend against having unmarked versions of versions though. Being able to trust that 1 version number = 1 copy of code is super important for many reasons 🙂

If I may offer a suggestion? I know it sucks to have a bunch of new versions in one day (like if you need to release each fix out ASAP). You could try a 4th version number for “hotfixes” — ACF 5.7.11.1, 5.7.11.2, etc. Once you’ve got them all, you can consider the latest hotfix as the only relevant version within the “5.7.11.X” series — so if you finish with 4 hotfixes, then in your download archive you’d have:

Download 5.7.10
Download 5.7.11.4
Download 5.7.12

In this way, you’d also be able to save 5.7.12 for an actual new release, rather then “5.7.12 – just bug fixes for 5.7.11” 🙂

A more involved idea:

I see you have free version of ACF on Github — I assume you have ACF PRO on Github as well, just set as private? It would be very interesting if you considered giving PRO members read access to the PRO repo. FontAwesome Pro works in this way which is where I got this idea. You could even market that as a new benefit of buying PRO. The reason I bring this up though, is that you could direct users to a specific branch for testing if you don’t want to release it publicly yet.

Hope this is helpful in some way!

Curtis