ACF Support

Support

Account

Forum Replies Created

Temporary workaround for anyone else having this issue:

function coerce_array_to_value( $value, $post_id, $field ) {
  if (
    $field['return_format'] === 'value' &&
    !$field['multiple'] &&
    is_array( $value ) &&
    array_key_exists( 0, $value )
  ) {
    $value = $value[0];
  }

  return $value;
}

add_filter( 'acf/load_value/type=select', array( $this, 'coerce_array_to_value' ), 10, 3 );

I’m still having this problem, even after upgrading to 5.7.1.

It’s exactly as @room34 describes it: A select set to return “value”. On posts that haven’t yet been saved with the new value, I’m expecting no value at all, but getting a 1-length array with the first item as the value.

This is tough to work around, because we’re trying to introduce a feature without having to touch existing posts. I’ll post a bug report.

adjTeam
in reply to: Revisions dont’t work, get php errors…
August 3, 2017 at 3:51 am

Thanks for the info @jenwachter .

FWIW, I’ll post here the fix to somewhat unrelated bugs I was experiencing with revisions that arose from trying to set the title of posts dynamically (based on ACF fields) on save.

If you try to set native WP fields in a save_post hook (or even acf_save_post), you’ll end up with “extra” bogus revisions, often which don’t restore properly, or restore but ignore ACF changed fields.

My fix was to listen for the wp_insert_post_data event, which I think ACF itself rides on, and make my change there, only referring to ACF fields by their ID since they wouldn’t be accessible via get_field at this point.


// Update dynamic title on save.
function bio_dynamic_title( $data, $postarr ) {
    // Bail if this isn't the right post type or if ACF wasn't submitted.
    if ( $data['post_type'] !== 'bio' || !array_key_exists( 'acf', $postarr ) ) {
      return $data;
    }

    $title = sanitize_text_field( full_name(
      $postarr['acf']['field_587e607692f49'], // first_name
      $postarr['acf']['field_589a17cb1cdd3'], // middle_initial
      $postarr['acf']['field_587e609192f4a'], // last_name
      $postarr['acf']['field_587e6ee94602b'] // suffix
    ));

    $data['post_title'] = $title;
    $data['post_name'] = sanitize_title( $title );

    return $data;
  }
  add_filter( 'wp_insert_post_data', 'bio_dynamic_title', 10, 2 );

- adjTeam
- in reply to: Revisions dont’t work, get php errors…
- June 29, 2017 at 5:13 am
Some further information after looking through stack traces: the warning is because WP, as part of restoring a revision, is calling normalize_whitespace() (which then calls trim()) on the values of ACF fields that are arrays, not strings.

Two instances of ACF fields that triggered this:
– A flex content’s base field
– A list of categories selected from a taxonomy field
- adjTeam
- in reply to: Revisions dont’t work, get php errors…
- June 29, 2017 at 3:21 am
I’m also getting these warnings when trying to restore revisions on a custom post type (also with the main editor hidden via ACF). Two versions I can verify display this problem: 5.5.10 and 5.5.14.

This is all because of a more primary bug I’m trying to troubleshoot: restoring revisions on custom post types seems to succeed, but all values in ACF fields stay the same instead of reverting.

I’ll keep at it and post if I have any further info on either of these (what appear to be) bugs…

adjTeam
in reply to: ACF Form Conditional Display
September 17, 2015 at 11:12 pm

For anyone suffering from this, I have a workaround that helps my particular case until the bug is fixed. This basically triggers a javascript “change” event on the Select2 component, which snaps the conditional logic into shape. This will only work for when there is at least one item in the select.


function acf_fix_select2( $field ) {
  if (
    !$field['ui'] ||                          // field isn't select2
    strpos( $field['id'], 'acfcloneindex' )   // field is hidden <select>
  ) {
    return;
  }

  ?>
    <script type="text/javascript">
      jQuery(function(){
        jQuery('#s2id_<?php echo $field['id']; ?> .select2-choices input:first')
          .trigger('change');
        acf.unload.off();
      });
    </script>
  <?php
}
add_action( 'acf/render_field/type=select', 'acf_fix_select2', 10, 1 );

- adjTeam
- in reply to: Conditional logic broken on some cases after updating to 5.2.6
- June 18, 2015 at 5:05 am
I have come across another instance of conditional logic acting weird on 5.2.6.

Add a stylized multi-select, and then add fields conditionally shown based on the value of the select. After saving, it seems the fields that should show based on the multiselect values disappear. They come back if you add/remove items, but is never shown correctly on first page load.

Version 5.2.5 doesn’t have this bug.
What will be the target version in which this bug will be fixed?
This is a huge issue for us right now.

Agreed. This is forcing us to downgrade/deliberately keep ACF out of date on every site we use it.
- adjTeam
- in reply to: acf/render_field documentation
- March 13, 2015 at 1:12 am
I can also confirm having pulled hair due to this. Please update the documentation for render_field!

adjTeam
in reply to: Concern about ACF get_fields() efficiency…
March 6, 2014 at 1:46 pm

Viewing 10 posts - 1 through 10 (of 10 total)

Advanced Custom Fields

Support

Account

Forum Replies Created

adjTeam

adjTeam

adjTeam

adjTeam

adjTeam

adjTeam

adjTeam

adjTeam

adjTeam

adjTeam

Welcome

Forums

Helping Others

About

Help

Community