Just ran into this one. It appears (though I’m not sure) that ACF and WP-Post-Meta-Revisions are redundant. I suspect that if you have ACF, you don’t need the other. I’d like clarification on that.
In the mean time I’ll be trying to discover why font end edits don’t trigger a revision.
That sounds cool, I’d like to see that. I just built a custom filtered search for our site and it was a beast to create enough posts of a custom type to test search against. I tried using LastPass’s custom form profile to auto fill but a lot of ACF’s great features like multi-select taxonomy and wyswyg are not accessible.
Just tried 5.3.1. Works great!
Save Terms and Load Terms are both set to Yes btw.
I just ran into this same problem. Taxonomies selected via ACF fields do update the actual use count. get_terms() only returns terms with a use count > 1.
The Issue
To illustrate the issue, lets say DevA and DevB have identical local copies.
1. DevA makes a change to My Field Group
2. acf-json/group_xxx.json is overwritten automatically
3. DevA commits and pushes group_xxx.json
4. DevB pulls group_xxx.json
5. DevB syncs My Field Group from within the ACF admin
6. acf-json/group_xxx.json is overwritten automatically
// now the bad stuff
7. DevB commits and pushes group_xxx.json (although the only thing that changed is the modified date)
8. DevA pulls and is notified by ACF admin that there is something to sync (although nothing has changed)
With poor communication this could conceivably go on forever.
What we do
Instead of step 7+ we immediately do a git checkout acf-json/group_xxx.json after a sync to stop the loop.
How does that work for your team though? We have a number of people working on the same project so for safety reasons, whenever someone saves a field group and commits, we must send out an alert that everyone should do an acf sync immediately after pulling. It’s inconvenient but not near as much as telling everyone to re-export production and then re-import locally. Besides that, the only real issue is that a new acf-json file is created after sync that is virtually identical to the one that was just imported aside from the change date. I’m thinking acf should not save new json immediately after sync.
I didn’t realize acf_save_post() returns early. That’s a far better approach imo since I can just leverage filters rather than hacky wet alterations.
There’s already enough client side validation to prevent an empty email field etc. so I’m marking your post as the answer. well done.
Hmm, not a bad idea to play with. That may create an issue as the form processor needs that goodies in there.
Here’s what I’m currently using as my solution but I’d love to hear if it’s faulty.
Basically I made a copy of acf_form_head() and removed the part that tries to update/create posts. Just put this before get_header() instead of acf_form_head()
https://gist.github.com/joelstransky/c87cc56923abe15b144b
I also need a fix for this. Not having a sticky toolbar is killing me.
