Filename conflict causes wp-cli to silently fail

• souverian

• March 30, 2017 at 8:50 am

I know you guys aren’t responsible for wp-cli but this is plugin-specific

Hey I’m developing a plugin for a client site and was having the weirdest issue. If I was in my plugin’s folder in terminal and ran any wp-cli command it would fail, but it would work just fine everywhere else. I checked my logs and saw this error:

Call to undefined function acf_include()

Long story short I narrowed the culprit down to acf pro and THEN figured out the conflict was because in my plugin I have a file here:

api/api-helpers.php

which conflicts with the ACF Pro file structure.

Bottom line is it seems like L95 of acf.php:

include_once('api/api-helpers.php');

isn’t namespaced so when run from the command line, if you happen to be in a directory where there is an alternate file with same relative path, it fails. It’s such a crazy specific issue! For now I’m going to rename my file or namespace it or something, but maybe you guys should do the same to prevent conflicts.

Thanks for your time,
Eli

• John Huebner

• March 30, 2017 at 9:45 am

I don’t know if this will help you but you should probably open a new support ticket here https://support.advancedcustomfields.com/new-ticket/

• souverian

• March 31, 2017 at 4:40 am

@hube2 I debated opening a ticket but I thought it’d be more helpful for other useres to be able to search for it on the forum. I’ll open a ticket now though, thanks.

• John Huebner

• April 1, 2017 at 3:51 am

Yes, it’s probably helpful to post it here if anyone else has a similar issue and finds this topic. But the part about namespacing ACF, that would need to go to the developer.

• souverian

• April 1, 2017 at 4:22 am

Thanks I opened a ticket yesterday and already got an answer.