Support

Account

Home Forums Bug Reports Field validation and toggle broken on PRO 5.6.6

Solved

Field validation and toggle broken on PRO 5.6.6

  • I’ve tested this on three separate websites, it appears that the field validation relating to fields that are conditional AND required is broken on the new version (PRO 5.6.6). When they are hidden, because the condition isn’t met, it still triggers a validation warning.

    I’m sometimes also unable or have difficulty toggling between radio fields, and the page seems to load slower than usual, but I’m not sure if that’s just on my end, or related to the above.

    The problem isn’t there with the exact same setup, but with the earlier version, 5.6.5.

    See attached for the field group I’ve encountered problems with: try the flexible content panels fields on a page, use the first one (content), and try to validate. The panel options tab has required, conditional fields for the background options (colour fill vs. images). Same for the number of columns, there are hidden WYSIWYG fields that want to be validated even though they’re hidden and validation should be skipped. You may need to save the page first, and try to resave it afterwards to get the error to come up.

  • I can also confirm that reverting back to 5.6.5 manually (replacing the main plugin folder) solves the problem.

  • I can confirm this bug. One workaround is to first save post as draft, then immediately publish. Hoping for quick fix.

  • Hi @updownupdown

    Thanks for the bug report,
    Elliot here – ACF dev.

    I’ve just imported your json (thanks for the export!) but am unable to replicate any conditional logic issues. I can add any layouts (including the first “content” layout) and all settings validate correctly.

    I can also confirm that the HTML “disabled” attribute is added to the field’s input elements.
    Perhaps this is a good place to start. Can you please inspect the field element that is hidden by conditional logic and check if it’s inputs are disabled?

    Thanks
    Elliot

  • This reply has been marked as private.
  • I also just reverted back to 5.6.5 to get rid of the validation issue and that solved my problem.

    I have radio buttons that toggle on and off different inputs. When I went to submit the conditional inputs that were hidden were still showing as required.

  • Hi @updownupdown

    I just tried your testing site but am unable to login. Here is the error message I see (raw HTML message, no WP):

    Whoops, something went wrong.
    We should be back in a few minutes.
    (Error 404 – Not Found)

    Can you please take a look at this. I am still not able t replicate this issue, but am aware a few developers are experiencing it.

  • Hi @updownupdown

    I just re-read your last comment, and am not a little confused about what the issue is.
    You say that you are unable to switch back from “Colour Fill” to “Background Type” because a

    I believe this is a CSS issue introduced in the latest version. This can easily be fixed by adding a ‘clear:both’ style attribute to the field.

    Is this the issue? I thought you were unable to save a post due to validation errors appearing for fields that are hidden?

  • This reply has been marked as private.
  • Hi @updownupdown

    Thanks for the reply. Looks like things are working now!
    I’ve logged in and can replicate the issue.

    This looks like a CSS bug causing the ‘label’ element to float over the top of other fields.
    The good news is that this is a super easy fix.

    I’ve pushed a hotfix to solve this layout problem. Can you please re-download the plugin and test that it is working?

    An easy way to re-download is to edit the main acf.php plugin file and change the version number ‘5.6.6’ down to ‘5.6.5’
    – please note the version number appears twice in this file and both will need to be changed
    – after this change is made, please update the plugin as per normal and it will update to 5.6.6 (including the new fix)​​​

    Keep me posted.

    Thanks
    Elliot

  • I was experiencing both the CSS issue as well as the validation error issue that other devs have mentioned. Your hotfix seems to have solved the CSS issue though!

    To recreate the validation issue, login to that demo website again, then do the following (I’ve greatly simplified the field group for testing):

    Go to Pages > Home, then “Add Flexible Panel”, select “Demo Panel”, then add dummy content in the “Content (1)” field (that one is required), then update the page. You’ll see “Validation failed. 3 fields require attention”. Those are hidden, conditional, required fields. To see them, switch “Number of Columns” from 1 to 4. You’ll see Content (2), Content (3), and Content (4), with the validation warning now visible.

  • Attached is the export of the simplified field group used on my demo site, it may help in recreating the error. Fairly straightforward. Not sure if the problem can be recreated in a simpler field group, like without using the flexible content field?

  • Hi @updownupdown

    Thanks for the reply. This is great!
    I can replicate the issue and will get to work on a fix for this too.

    It looks like the problem only affects newly added flexible content fields. After toggling a conditional logic trigger, the issue resolves itself.

    I’ll do some tests and find how many other field’s this affects

  • Hi @updownupdown

    Good news. I was able to find and understand the issue. A very minor 1 line change has sorted out the problem.

    Can you please use the above steps to “upgrade to 5.6.6” again? Please let me know if this solves the issue.

  • Tested, everything working and back to normal, thanks!!!

Viewing 16 posts - 1 through 16 (of 16 total)

You must be logged in to reply to this topic.