Conditionals of Subfield disappear on save

• benjaminpick

• November 12, 2013 at 5:12 am

Many many thanks for the repeater conditional Support!

Unfortunately I’ve found inconsistent behavior. I have reproduced it using the following steps.

1) Create a new field group.
2) Create a radio/select field that has 7 alternatives to choose from (these are subtypes)
3) Create a repeater field with a text subfield. This subfield has the conditional “if type is 1 or 2 or 3 or 4 or 6 or 7”.
4) Save the field group.
5) Then look for the conditional rules of the subfield.

Expected: the rules are still the same.
Actual behavior: some rules are missing.

• Elliot

• November 12, 2013 at 4:49 pm

Hi @benjaminpick

Thanks for the bug report.

I’ll do some testing.

Thanks
E

• benjaminpick

• November 13, 2013 at 10:29 pm

Could you reproduce the issue? Or should I create a clean install and try there?

• Elliot

• November 14, 2013 at 10:22 am

Hi @benjaminpick

I can confirm that on my local install, I can create a text sub field which contains tall 7 conditional logic rules from the 7 radio button choices…

I would try on a clean install. You may find that the issue was more to do with a server limit on how many variables can be posted at one time.

Hope that helps.

Thanks
E

• inspireddevelopment

• November 19, 2013 at 12:06 am

I have the same issue. I can save 2 lines conditional options but adding a 3rd conditional requirement fails and the new ruels are not saved.

• inspireddevelopment

• November 19, 2013 at 12:47 am

Ok, I resolved this. Couple of things to try – Ensure that the order of conditionals is correct, I had mine a bit messed, was adding an item in the middle instead of appending it to the end. I also increased the max_input_vars tp 6000 and threw the max_input_nesting_level to 10000.. I cannot say if they made a difference, I have limited time to test, I’m fairly confident that its the order that caused it to remove conditionals…

• Elliot

• November 21, 2013 at 10:34 am

Hi guys

Thanks for the bug report.
I have tracked down and fixed the issue. You will find a fix in the github repo.

The issue was caused when you add a new rule but use a ‘+’ button which is not the last one in the list.

Thanks
E

• benjaminpick

• November 25, 2013 at 8:47 pm

Many thanks! Updating ACF & ACF Repeater solved the issue.
However, there is a little visual glitch: the margin-top of .acf-button-add.add-row-before needs to recalculated each time that the conditional display changes (right now, the plus sign “create a new repeating element” jumps up and down), not only on mousenter of the row.

Bildschirmfo....png

• benjaminpick

• November 25, 2013 at 10:26 pm

I also had to increase max_input_vars for my mega custom type …

• Elliot

• November 26, 2013 at 10:45 am

Hi @benjaminpick

Thanks for the bug report. I’ll add this to the todo and have a solution soon

Thanks
E

• Elliot

• November 28, 2013 at 1:20 pm

Hi @benjaminpick

Thanks again for the UI bug. I have found and fixed this issue. All that was needed was to trigger a ‘mouseover’ event when a sub field was conditionaly hidden / revealed.

I have pushed the fix to the repeater field repo, so you can re-download the add-on to get this code fix.

I won’t release this as a new version just yet, I will wait to bundle some more fixes.

Thanks
E