'Allow Null' Option Value Should be Consistent Between Fieldtypes

• ryanjbonnell

• October 4, 2013 at 6:14 am

When using the Taxonomy fieldtype with “Allow Null” set to “Yes”, the default option is presented as "None":

<option value=””>None</option>

This is in direct contrast with fieldtypes that use also a <select> but present the null value as " - Select - ":

<option value=”null”> – Select – </option>

For consistency, the two should use the same convention; I suggest using " - Select - " everywhere:

acf / core / fields / select.php (Line 109)
https://github.com/elliotcondon/acf/blob/master/core/fields/select.php#L109

acf / core / fields / taxonomy.php (Line 211)
https://github.com/elliotcondon/acf/blob/master/core/fields/taxonomy.php#L222

Consider the following option values:

None
All
Any
None

– Select –
All
Any
None

Having " - Select - " appear as the null value (with dashes) is a *way better visual indication* that’s it not one of the valid values.

I prefer the separation the dashes give, as it clearly differentiates the null value from others in the list. Without the dashes, it’s too easy to confuse the null value with the other values.

Also, the Taxonomy fieldtype could benefit from having an ID on the HTML <select> element, which would better allow it to be used by JavaScript and jQuery or for conditional logic.

• Elliot

• October 4, 2013 at 2:13 pm

Hi @ryanjbonnell

Thanks for the report.

Yes, I agree with you completely. I’ll add this to the to-do

Cheers
E

• ryanjbonnell

• October 4, 2013 at 5:07 pm

Fantastic. Keep up the great work!