ACF_Local_JSON calls get_stylesheet_directory too early

• destination

• November 13, 2023 at 7:23 am

Hey there,

The ACF_Local_JSON class is calling get_stylesheet_directory() within its constructor before any filters are able to run on it:

// Update settings.
acf_update_setting( 'save_json', get_stylesheet_directory() . '/acf-json' );
acf_append_setting( 'load_json', get_stylesheet_directory() . '/acf-json' );

These calls should be made within an init hook or similar to give plugins or themes a chance to filter stylesheet_directory and/or stylesheet

This is causing a major breakage for us in WordPress 6.4 as the result of get_stylesheet_directory() is now memoized meaning our filters never run.