The filter is not being called because you are using a checkbox field.
When using a checkbox field ACF uses wp_list_categories() as well as a different filter that is documented there https://www.advancedcustomfields.com/resources/acf-fields-taxonomy-wp_list_categories/
Sorry for not catching this sooner.
