the_sub_field() echos the value of the field. The result of an echo is always true. You need to use get_sub_field()
<?php if( get_sub_field('popular') == 'Yes' ): ?>
Correct Answer
<?php elseif( get_sub_field('popular') == 'No' ): ?>
Wrong answer
?php endif; ?>