Home › Forums › Backend Issues (wp-admin) › Unnecessary AJAX-calls › Reply To: Unnecessary AJAX-calls
I’ve come up with a rudimentary patch to input.js that solves the excessive $.each() and $el.closest() calls when there is an excessive amount of repeatables.
changing this:
get_visibility : function( $target, rule ){
//console.log( 'conditional_logic.get_visibility(%o, %o)', $target, rule );
// update cache (cache is cleared after render_fields)
if( !acf.isset(this.cache, rule.field) ) {
//console.log('get_fields(%o)', rule.field);
// get all fields for this field_key and store in cache
this.cache[ rule.field ] = acf.get_fields(rule.field, false, true);
}
// vars
var $triggers = this.cache[ rule.field ],
$trigger = null;
// bail early if no triggers found
if( !$triggers.exists() ) {
return false;
}
// set $trigger
$trigger = $triggers.first();
// find better $trigger
if( $triggers.length > 1 ) {
$triggers.each(function(){
// vars
$parent = $(this).parent();
if( $target.closest( $parent ).exists() ) {
$trigger = $(this);
return false;
}
});
}
// calculate
var visibility = this.calculate( rule, $trigger, $target );
// return
return visibility;
},
To this:
get_visibility : function( $target, rule ){
//console.log( 'conditional_logic.get_visibility(%o, %o)', $target, rule );
// update cache (cache is cleared after render_fields)
if( !acf.isset(this.cache, rule.field) ) {
//console.log('get_fields(%o)', rule.field);
// get all fields for this field_key and store in cache
this.cache[ rule.field ] = acf.get_fields(rule.field, false, true);
}
// vars
var $triggers = this.cache[ rule.field ],
/*change*/ $trigger = $target.closest('.acf-row').find('tr.field_key-'+rule.field);
// bail early if no triggers found
if( !$triggers.exists() ) {
return false;
}
/*change*/ else if ( !$trigger.exists() ) {
// set $trigger
$trigger = $triggers.first();
// find better $trigger
if( $triggers.length > 1 ) {
$triggers.each(function(){
// vars
$parent = $(this).parent();
if( $target.closest( $parent ).exists() ) {
$trigger = $(this);
return false;
}
});
}
}
// calculate
var visibility = this.calculate( rule, $trigger, $target );
// return
return visibility;
}
Welcome to the Advanced Custom Fields community forum.
Browse through ideas, snippets of code, questions and answers between fellow ACF users
Helping others is a great way to earn karma, gain badges and help ACF development!
We've just released ACF 5.12.3 with a security fix to prevent arbitrary file uploads to forms with ACF fields.
— Advanced Custom Fields (@wp_acf) July 14, 2022
Now that we've released this update, we recommend updating your sites as soon as possible.
© 2022 Advanced Custom Fields.
We use cookies to offer you a better browsing experience, analyze site traffic and personalize content. Read about how we use cookies and how you can control them in our Cookie Policy. If you continue to use this site, you consent to our use of cookies.