Support

So first. Love ACF.

I have a suggestion for your location rules. Currently your plugin's location rules will return true as a parent page for any top level page. So your current parent check will output field groups the same as your post type = page (a bit of a redundancy). But I would argue that a parent page is only a parent when it has child pages. So my suggestion would be to replace your location rule for the parent type. I'm using this on line 1314 of acf.php:


if( $rule['value'] == 'parent')
{
$post_parent = wp_list_pages( 'echo=0&child_of=' . $post->ID . '&title_li=' );
if( isset($overrides['page_parent']) )
{
$post_parent = (int) $overrides['page_parent'];
}

if( $rule['operator'] == "==" )
{
if( $post_parent )
{
return true;
}
}
elseif( $rule['operator'] == "!=" )
{
if( !$post_parent )
{
return true;
}
}

return false;
}

Now there may be a better way of doing this check but it corrects the logic as I think it should. Anyway, thanks so much for all your hard work.

- ben